Skip to content

[7.0] Remove LegacyPropertyManagementTrait from User class#44906

Merged
laoneo merged 7 commits into
joomla:7.0-devfrom
Hackwar:6.0-user-propertytrait
Jun 19, 2026
Merged

[7.0] Remove LegacyPropertyManagementTrait from User class#44906
laoneo merged 7 commits into
joomla:7.0-devfrom
Hackwar:6.0-user-propertytrait

Conversation

@Hackwar

@Hackwar Hackwar commented Feb 14, 2025

Copy link
Copy Markdown
Member

Summary of Changes

The LegacyPropertyManagementTrait has been deprecated for a long time and will probably be removed in 7.0. This PR removes its inclusion in the User class for Joomla 7.0.

Testing Instructions

Codereview

Link to documentations

Please select:

@Hackwar Hackwar added Feature b/c break This item changes the behavior in an incompatible why. HEADS UP labels Feb 14, 2025
@HLeithner HLeithner changed the base branch from 6.0-dev to 6.1-dev August 31, 2025 11:57
@HLeithner

Copy link
Copy Markdown
Member

This pull request has been automatically rebased to 6.1-dev.

@HLeithner HLeithner changed the title [6.0] Remove LegacyPropertyManagementTrait from User class [6.1] Remove LegacyPropertyManagementTrait from User class Aug 31, 2025
@Hackwar Hackwar changed the base branch from 6.1-dev to 7.0-dev February 28, 2026 14:17
@Hackwar Hackwar changed the title [6.1] Remove LegacyPropertyManagementTrait from User class [7.0] Remove LegacyPropertyManagementTrait from User class Feb 28, 2026
@Hackwar Hackwar marked this pull request as ready for review April 20, 2026 20:52
@laoneo

laoneo commented May 19, 2026

Copy link
Copy Markdown
Member

I would say that this is too early as it can break extensions, overrides and custom code.

@Hackwar

Hackwar commented May 19, 2026

Copy link
Copy Markdown
Member Author

This has been deprecated for 10 years, so I don't see how this would change anything if we wait any longer.

@laoneo

laoneo commented May 20, 2026

Copy link
Copy Markdown
Member

Better to add a get function to the User class and throw an exception when the compat plugin is disabled.

@laoneo laoneo added the Architecture Pull requests which improve the architecture. label Jun 18, 2026
@laoneo laoneo merged commit b0069b2 into joomla:7.0-dev Jun 19, 2026
55 of 56 checks passed
@laoneo

laoneo commented Jun 19, 2026

Copy link
Copy Markdown
Member

Thanks!

@laoneo laoneo added this to the Joomla! 7.0.0 milestone Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Pull requests which improve the architecture. b/c break This item changes the behavior in an incompatible why. HEADS UP Feature PR-7.0-dev Removal Removes functionality

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants