added helper methods to get and directly set trauma - #15
Open
piedoom wants to merge 2 commits into
Open
Conversation
added 2 commits
July 1, 2025 13:07
Owner
|
Sorry, I forgot to check PRs before releasing. I guess your use-case probably makes sense, but I wonder if it's simpler to just make the field public. I think that's the common pattern in most bevy crates to keep it simple stupid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many cases, additive trauma is not desirable. This adds two methods to
Shakethat allow for user-defined control:set_trauma: directly sets the trauma valuetrauma: gets the current trauma valueThis also adds the
set_traumato theShakesconvenience params.This solves #8 as well