An optimized get_kmer_frequencies.pl - #1
Open
duffee wants to merge 2 commits into
Open
Conversation
Made to run faster than the python re-write
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Jennifer,
I saw your dev.to post on get_kmer_frequencies and it motivated me to make it run faster. This is the result written in my own style and optimized. It should be 40% faster than your python re-write. It's taken me much longer to finish the reply to your post detailing the steps I took, but this PR is a first look at the end product. I've put it in its own directory, but it's up to you what you want to do with it. Feel free to decline the PR. For me, it's just the mechanism that git has for showing off code. I suppose if I'd just replaced the original one, you'd get to see the coloured diff, but that felt a little presumptuous. Thank you for an enjoyable challenge.
best wishes,
Boyd