feat(auth_hybrid_matrix_token): add a prosody var to disable room membership verification#48
Merged
Merged
Conversation
…bership verification
Member
|
I updated some minor things after merged. Could you check the latest version to be sure it is working. By the way, I think you already know, Matrix users will be always moderator in Jitsi when membership verification is disabled. |
Author
|
Hi, It still works as it should after your changes, perfect Yes I noticed this behaviour too, but it's fine by me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the module always calls the
/verify/user_in_roomendpoint of UVS, which requires a Synapse admin user token to work, and will only work on Synapse.This PR adds a Prosody config option that disables room membership verification, and only checks if the user exists.