Skip to content

Remove empty objects, as well as keep 0 and false with remove_empty_properties #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thatnerdjosh wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove empty objects, as well as keep 0 and false with remove_empty_properties #736

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0d2a2c
fix for sending 0 and false with remove_empty_properties=true
dexif Feb 24, 2017
957b1c1
Add empty object deletion
Mar 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/editors/object.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,7 @@ JSONEditor.defaults.editors.object = JSONEditor.AbstractEditor.extend({
if(this.jsoneditor.options.remove_empty_properties || this.options.remove_empty_properties) {
for(var i in result) {
if(result.hasOwnProperty(i)) {
if(typeof result[i] === 'undefined' || result[i] === '') delete result[i];
if(typeof result[i] === 'undefined' || result[i] === '' || Object.keys(result[i]).length == 0 && result[i].constructor == Object) delete result[i];

@dexif dexif Apr 28, 2017 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong logic. It's should be...
Oh... And you should check if result[i] == null

if(typeof result[i] === 'undefined' || result[i] === '' || (result[i] !== null && Object.keys(result[i]).length == 0 && result[i].constructor == Object)) delete result[i];

}
}
}
Expand Down