Skip to content

support compile with C++ compiler (MinGW G++)#1778

Draft
guan-das-jounior wants to merge 10 commits into
janet-lang:masterfrom
guan-das-jounior:master
Draft

support compile with C++ compiler (MinGW G++)#1778
guan-das-jounior wants to merge 10 commits into
janet-lang:masterfrom
guan-das-jounior:master

Conversation

@guan-das-jounior

@guan-das-jounior guan-das-jounior commented Jul 3, 2026

Copy link
Copy Markdown

Hi.

I would be able to compile with G++ on win 11
please keep the PR (if you do not plan to merge it) for future people who face this issue too.
-- thanks in advance


summary of work:

  • mostly removed gotos
  • implicit enum -> explicit enum
  • template -> template_ since in C++ template is a keyword

@guan-das-jounior guan-das-jounior changed the title support compile with C++ compiler support compile with C++ compiler (MinGW G++) Jul 3, 2026
@bakpakin

bakpakin commented Jul 4, 2026

Copy link
Copy Markdown
Member

Welcome to github! I appreciate the effort, but I think there are some barriers on how to contribute code that are getting in the way.

First, why so many unrelated changes like removing gotos? Generally, the better way to do this sort of thing is to make a minimal change (the only thing that seems needed would be the build script and the renaming of template -> _template), as well as a test build so it doesn't regress.

Second, it's confusing if you keep pushing changes to the same pull request with lots of unrelated changes. Either mark this as a draft, do development in your own local copy only or your own fork, and only make a PR when you are confident enough to get feedback and have the change merged as is.

Last, I don't think being able to compile with C++ is that much of a goal, although I appreciate it might be good for some workflows. Usually you can link C and C++ code together with a common linker.

@bakpakin

bakpakin commented Jul 4, 2026

Copy link
Copy Markdown
Member

Also, please configure your git client to have a commit author name as something other than "Your Name". Perhaps I am wrong, but you seem new to this and I'm not too confident on merging unsolicited changes from a brand new account.

@guan-das-jounior guan-das-jounior marked this pull request as draft July 4, 2026 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants