[feat] upgrading to flink 2.x - #172
Merged
Merged
Conversation
goyal-anshul
marked this pull request as ready for review
November 27, 2025 14:26
itinycheng
self-requested a review
December 3, 2025 03:50
itinycheng
approved these changes
Dec 4, 2025
itinycheng
left a comment
Owner
There was a problem hiding this comment.
I plan to merge the code first and will submit a PR later to fix the CI error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #171.
Brief change log
1.19to2.1OutputFormatfunctionality as it is, to minimize the overall changes. As a result, I added a new methodopen()that does the same as the previousopen(int, int)method. Since theOutputFormatinterface is updated, I had to keep the methodopen(InitializationContext)but it is unused.How was this patch tested?
I generated the jar file locally using
mvn clean package. I then used the generated jar file in my local flink-sql pipeline for testing.Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation