Conversation
byteocean
force-pushed
the
enh/pick
branch
2 times, most recently
from
June 12, 2026 13:54
e6d282f to
febd0de
Compare
Replaced error returns with log messages and null returns when no LoadBalancer is registered for the given VNI and IP. This prevents abrupt failures and provides better visibility through logs. Signed-off-by: Tao Li <tao.li06@sap.com>
mainly due to restart of metalnet Signed-off-by: Tao Li <tao.li06@sap.com>
mkalcok
reviewed
Jul 17, 2026
mkalcok
left a comment
mkalcok
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM, thank you.
I have one nit with the second commit (Defer connecting with metalbond and replay routes the lb targets) as a whole though. Would you mind splitting it in two separate commits with more detailed message?
Especially the change that moves mbInstance.AddPeer() couple of lines down, could benefit from explaining how exactly it helps. It's not clear to me just from the diff alone. Is it preventing some sort of race condition?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mitigate false alarm when LB target routes arrive at a non-LB node.
Re-add received LB target routes once LB is created, to ensure no LB target route is missing in dpservice.