feat(config): add STATS_EVENTS_USE_NAIVE_UTC_DATETIME flag#168
Conversation
zzacharo
force-pushed
the
events-timezone-flag
branch
from
03797f6 to
a35dd21
Compare
| Default behaviour will register the templates as search templates. | ||
| """ | ||
|
|
||
| STATS_EVENTS_USE_NAIVE_UTC_DATETIME = True |
There was a problem hiding this comment.
setting it to True is for the migration purpose a good value. we play it safe, because with this setting it can't fail. But for a new instance this value leads to a necessary configuration to use the utc aware datetimes and this seems really strange. as a newcomer i would not expect that i have to configure it that way.
for me it would be better to set this value to False as the default value. Old instance which do a live update have to configure it, but instances which do mostly what is written in the migration steps do a index destroy with a full reindex and therefore don't need this flag at all.
There was a problem hiding this comment.
The index destroy doesnt affect the stats indices so they will be affected if they have already stat events. I think it would be easier to opt-in and describe the needed steps. WDYT?
Introduce STATS_EVENTS_UTC_DATETIME_ENABLED (default: False) to strip tzinfo from event timestamps at build time. Set to True to opt-in to timezone-aware UTC datetimes.
zzacharo
force-pushed
the
events-timezone-flag
branch
from
a35dd21 to
a6f04c1
Compare
2 participants
Introduce STATS_EVENTS_USE_NAIVE_UTC_DATETIME (default: True) to strip tzinfo from event timestamps at build time. Set to False to opt-in to timezone-aware UTC datetimes.