Skip to content

fix(components): use ClipboardItem API for Safari-compatible clipboard writes #3379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djchrisssssss wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(components): use ClipboardItem API for Safari-compatible clipboard writes #3379

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f819fb
fix(components): use ClipboardItem API for Safari-compatible clipboar…
djchrisssssss Mar 21, 2026
3e3a1bf
refactor(components): simplify CopyButton with unified dataPromise
djchrisssssss Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/components/CopyButton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,29 @@ import { Button, Popup } from "semantic-ui-react";
import { i18next } from "@translations/invenio_app_rdm/i18next";

class SimpleCopyButton extends React.Component {
fetchUrl = async (url) => {
return await (await fetch(url)).text();
};

handleClick = async () => {
handleClick = () => {
const { url, text, onCopy } = this.props;
let textToCopy = text;
if (url) {
textToCopy = await this.fetchUrl(url);
}

await navigator.clipboard.writeText(textToCopy);
onCopy(text);
// Resolve what to copy: fetch from URL or use text directly.
// Safari requires clipboard writes to occur synchronously within the
// user-gesture call stack. Using async/await with fetch() breaks this
// chain. The ClipboardItem API accepts a Promise, keeping the
// clipboard.write() call synchronous while resolving data internally.
const dataPromise = url
? fetch(url).then((response) => response.text())
: Promise.resolve(text);

if (typeof ClipboardItem !== "undefined") {
const item = new ClipboardItem({
"text/plain": dataPromise.then((t) => new Blob([t], { type: "text/plain" })),
});
navigator.clipboard.write([item]).then(() => onCopy(text));
} else {
// Fallback for browsers where ClipboardItem is not available
dataPromise.then((t) =>
navigator.clipboard.writeText(t).then(() => onCopy(text))
);
}
};

render() {
Expand Down
Loading