feat: Added popup to warn about 191 chars max limit#3333
Open
jmarcoz1 wants to merge 3 commits into
Open
Conversation
fab1c70 to
1fe45dd
Compare
slint
approved these changes
Apr 28, 2026
slint
left a comment
Member
There was a problem hiding this comment.
Sorry, a bit late to review this, many thanks for the contribution! Overall the code looks good. Before merging can you:
- add a screenshot of how this looks like now?
- run the linter/formatter to fix the JS CI?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Closes #3261
Description
As stated in this issue: #3261, a limit has been enforced on the length of the version field to 191 characters at most. In this repository, marshmallow validation and a hard limit on the version field and a max-length property has been added to VersionFieldComponent. In invenio-rdm-records, a popup warning about the limit has been added.
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: