Skip to content

feat: Added popup to warn about 191 chars max limit#3333

Open
jmarcoz1 wants to merge 3 commits into
inveniosoftware:masterfrom
jmarcoz1:feat/3261-version-field-character-limit
Open

feat: Added popup to warn about 191 chars max limit#3333
jmarcoz1 wants to merge 3 commits into
inveniosoftware:masterfrom
jmarcoz1:feat/3261-version-field-character-limit

Conversation

@jmarcoz1

@jmarcoz1 jmarcoz1 commented Feb 22, 2026

Copy link
Copy Markdown

❤️ Thank you for your contribution!

Closes #3261

Description

Please describe briefly your pull request.

As stated in this issue: #3261, a limit has been enforced on the length of the version field to 191 characters at most. In this repository, marshmallow validation and a hard limit on the version field and a max-length property has been added to VersionFieldComponent. In invenio-rdm-records, a popup warning about the limit has been added.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@jmarcoz1 jmarcoz1 force-pushed the feat/3261-version-field-character-limit branch from fab1c70 to 1fe45dd Compare February 24, 2026 06:41

@slint slint left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, a bit late to review this, many thanks for the contribution! Overall the code looks good. Before merging can you:

  1. add a screenshot of how this looks like now?
  2. run the linter/formatter to fix the JS CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deposit: version field should have a character limit

4 participants