Update SVS_URL to nightly with get_memory_breakdown#357
Merged
Conversation
Bumps the pinned LTO prebuilt SVS library from the 2026-05-21 nightly to 2026-07-21, which includes get_memory_usage()/get_memory_breakdown() (#345). Fixes the "with static library, ON" runtime-bindings CI job, which linked the runtime bindings against a prebuilt lib predating those methods: no member named 'get_memory_breakdown' in 'svs::DynamicVamana'
yuejiaointel
requested review from
ahuber21,
ethanglaser and
ibhati
as code owners
July 21, 2026 19:05
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the pinned LTO prebuilt SVS library (
bindings/cpp/CMakeLists.txt) fromsvs-shared-library-lto-nightly-2026-05-21-1429tosvs-shared-library-lto-nightly-2026-07-21-127, which includesget_memory_usage()/get_memory_breakdown()(#345).Why
The
Build and unit tests for C++ runtime bindings (with static library, ON)job links the runtime bindings against this prebuilt lib. The previously-pinned nightly predated #345, so it failed:The new nightly was built from
main(post-#345, via the private-repo submodule bump intel-innersource#338) and ships the method — verified the tarball's headers containget_memory_breakdown. This should turn that CI job green.Follows the pattern of #311 (Update SVS_URL in binaries).