Skip to content

Fix the timer plugin (init crash, missed load, unstyled) #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DmitrySharabin wants to merge 3 commits into
base: main
Choose a base branch
from
+17 −6
Open

Fix the timer plugin (init crash, missed load, unstyled) #5

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1af8fa6
Fix timer plugin crashing on init (this is undefined in ESM)
DmitrySharabin Jun 10, 2026
9655bbc
Start the timer even if it loads after the load event
DmitrySharabin Jun 10, 2026
a56bad8
Load the timer plugin's stylesheet (hasCSS was missing)
DmitrySharabin Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions timer/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,30 @@
import Inspire from "@inspirejs/core";

export const hasCSS = true;

Inspire.hooks.add("init-start", me => {
// Create timer, if needed
this.duration = document.body.getAttribute("data-duration");
let duration = document.body.getAttribute("data-duration");

if (this.duration > 0) {
if (duration > 0) {
document.body.insertAdjacentHTML(
"beforeend",
`<div id="timer" style="transition-duration: ${this.duration * 60}s;"></div>`,
`<div id="timer" style="transition-duration: ${duration * 60}s;"></div>`,
);

addEventListener("load", evt => {
// Start the countdown on load — or right away if the plugin loaded after
// the load event already fired, so a late load isn't missed.
let start = () => {
timer.className = "end";

setTimeout(() => timer.classList.add("overtime"), this.duration * 60000);
});
setTimeout(() => timer.classList.add("overtime"), duration * 60000);
};

if (document.readyState === "complete") {
start();
}
else {
addEventListener("load", start);
}
}
});