Skip to content

refactor(app): Extract bootstrap and validators modules from app.rs - #211

Merged
rnbguy merged 13 commits into
mainfrom
marius/bootstrap-refactor
Feb 6, 2026
Merged

refactor(app): Extract bootstrap and validators modules from app.rs#211
rnbguy merged 13 commits into
mainfrom
marius/bootstrap-refactor

Conversation

@mpoke

@mpoke mpoke commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Extract node initialization logic (genesis and existing block recovery) into new bootstrap.rs module
  • Extract validator contract interaction and parsing logic into new validators.rs module with unit tests
  • Reduce app.rs by ~270 lines, improving code organization and testability

@mpoke
mpoke requested a review from a team as a code owner February 5, 2026 18:50
@rnbguy
rnbguy self-requested a review February 6, 2026 10:17

@rnbguy rnbguy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup ! 🙏🏼

ps. fix the clippy lint.

Comment thread app/src/bootstrap.rs Outdated
Comment thread app/src/bootstrap.rs Outdated
Comment thread app/src/bootstrap.rs Outdated
Comment thread app/src/bootstrap.rs Outdated
Comment thread app/src/bootstrap.rs Outdated
Comment thread app/src/bootstrap.rs Outdated
Comment thread app/src/bootstrap.rs Outdated
mpoke and others added 7 commits February 6, 2026 12:32
Co-authored-by: Rano | Ranadeep <ranadeep@informal.systems>
Co-authored-by: Rano | Ranadeep <ranadeep@informal.systems>
Co-authored-by: Rano | Ranadeep <ranadeep@informal.systems>
Co-authored-by: Rano | Ranadeep <ranadeep@informal.systems>

@rnbguy rnbguy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@rnbguy
rnbguy merged commit 5d10255 into main Feb 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants