fix suffix range handling in cached object store get_opts#27529
Open
naruto-lgtm wants to merge 1 commit into
Open
fix suffix range handling in cached object store get_opts#27529naruto-lgtm wants to merge 1 commit into
naruto-lgtm wants to merge 1 commit into
Conversation
Author
|
any update? |
1 similar comment
Author
|
any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Repro: read any cached parquet object with a suffix range (
bytes=-N) throughMemCachedObjectStore, then compare with the same read against the backing store. They disagree.Cause:
get_optshand-rolls theGetRangeto byte-offset conversion and mapsSuffix(n)to0..n, so it returns the first n bytes instead of the last n. The same match also errors on a bounded range whose end runs past the object rather than clamping it, which diverges from theObjectStorecontract thatget_ranges/the inner store follow.Fix: delegate to
object_store's ownGetRange::as_range(len), which implements the documented Suffix/Offset/Bounded semantics, so a cache hit returns the same bytes as the backing store. Added a regression test over all three range kinds.