Skip to content

[WIP] Allow Jennifer::Migration::Runner.migrate to specify an adapter.#333

Open
didactic-drunk wants to merge 1 commit into
imdrasil:masterfrom
didactic-drunk:shard_migrate
Open

[WIP] Allow Jennifer::Migration::Runner.migrate to specify an adapter.#333
didactic-drunk wants to merge 1 commit into
imdrasil:masterfrom
didactic-drunk:shard_migrate

Conversation

@didactic-drunk

Copy link
Copy Markdown
Contributor

This partially to support sharding. New shards may be brought online or have been offline for some time requiring migration Version tracking per shard.

I'm stuck here.

private def self.process_up_migration(migration, adapter)
        optional_transaction(migration) do
          process_with_announcement(migration, :up) do
            migration.up
            Version.create(version: migration.class.version)
          end
        end

How do I cleanly pass the adapter to

  • optional_transaction(migration)
  • process_with_announcement(migration, :up) do
  • migration.up

As arguments? Using a class var like I did for Version? Other?

Migration
Allow Jennifer::Migration::Runner.migrate to specify an adapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant