Update to support zig 0.14.0-dev.1583+812557bfd#41
Open
pfgithub wants to merge 7 commits into
Open
Conversation
Co-authored-by: Nigel Baillie <nigel@baillie.dev>
ikskuh
requested changes
Sep 29, 2024
Author
There was a problem hiding this comment.
that seems to have came from the first commit in the zig 12 support PR, I'm not sure why it's there
Comment on lines
-93
to
+82
| .root_source_file = .{ .path = sdkRoot() ++ "/tools/zip_add.zig" }, | ||
| .root_source_file = b.path("tools/zip_add.zig"), |
Owner
There was a problem hiding this comment.
This change is breaking as it now only allows to compile this repository, but you can't use the Sdk.zig anymore from any other path except project root.
Until we gain ability to run it properly from a zig dependency, we have to ues .{ .cwd_relative = … }
Author
There was a problem hiding this comment.
That change is entirely in the last commit so it can be reverted. I would have added package manager support but I decided to use android studio instead of this
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.