Skip to content

Fix HTC transition range blending#33359

Open
kyriv-lab wants to merge 2 commits into
idaholab:nextfrom
kyriv-lab:HTC_transient_range_correction
Open

Fix HTC transition range blending#33359
kyriv-lab wants to merge 2 commits into
idaholab:nextfrom
kyriv-lab:HTC_transient_range_correction

Conversation

@kyriv-lab

Copy link
Copy Markdown
Contributor

This PR resolves issue #33357

Evaluate turbulent HTC correlations at the turbulent Reynolds endpoint when blending through the transition range, then update affected gold outputs.

Refs idaholab#33357
@moosebuild

Copy link
Copy Markdown
Contributor

Job Precheck, step Clang format on 542c2d5 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/33359/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 7b332444532bd42dee0e095a07e0999fca53a136

@moosebuild

Copy link
Copy Markdown
Contributor

Job Test, step Results summary on 04c9142 wanted to post the following:

Framework test summary

Compared against 7b33244 in job civet.inl.gov/job/3978475.

No change

Modules test summary

Compared against 7b33244 in job civet.inl.gov/job/3978475.

No added tests

Run time changes

Test Base (s) Head (s) +/- Base (MB) Head (MB)
misc/test:sensor_postprocessor.time_delay_test 2.05 3.11 +52.20% 109.53 111.63

@moosebuild

Copy link
Copy Markdown
Contributor

Job Documentation, step Docs: sync website on 04c9142 wanted to post the following:

View the site here

This comment will be updated on new commits.

@kyriv-lab
kyriv-lab marked this pull request as ready for review July 16, 2026 20:02
@kyriv-lab

Copy link
Copy Markdown
Contributor Author

@GiudGiud please review.

@GiudGiud GiudGiud self-assigned this Jul 16, 2026
@moosebuild

Copy link
Copy Markdown
Contributor

Job Coverage, step Generate coverage on 04c9142 wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Subchannel

7b3324 #33359 04c914
Total Total +/- New
Rate 93.38% 93.40% +0.01% 100.00%
Hits 6324 6335 +11 25
Misses 448 448 - 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

GiudGiud
GiudGiud previously approved these changes Jul 16, 2026

@GiudGiud GiudGiud left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good catch
@tanoret for technical review the changes in results are significant

@GiudGiud
GiudGiud dismissed their stale review July 16, 2026 21:18

Should we be blending Nu for all these correlations?

The correlations don't mention blending

@GiudGiud

Copy link
Copy Markdown
Contributor

Seems the range in Pe number in Borishanskii is intended to cover laminar and turbulent regime. So we should not be blending that one.
What do we do now?

@kyriv-lab

Copy link
Copy Markdown
Contributor Author

Pe: Re * Pr. And Borishanskii has a valid formula for Pe <=200. Pr for sodium is very low: about 0.004 to 0.006. So that means that the Re number for this region can still be turbulent.

Todreas & Kazimi present their heat-transfer correlations in the chapter HEAT TRANSFER CORRELATIONS IN TURBULENT FLOW.

So I don't think this is an issue.

Additionally in the original paper the Re number is in the turbulent regime:
Screenshot 2026-07-16 at 4 00 14 PM

@GiudGiud

GiudGiud commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Where did blending Nu come from ? T&K?

@GiudGiud

Copy link
Copy Markdown
Contributor

Let's consider Gnielinski that is essentially defined in the transition range (down to Re > 2300). Do we adapt our info.ReT to avoid blending it?

@kyriv-lab

Copy link
Copy Markdown
Contributor Author

Where did blending Nu come from ? T&K?
@tanoret implemented the blending Nu idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants