IBX-12091: Added TypeScript translation extraction support#1967
Open
mikadamczyk wants to merge 6 commits into
Open
IBX-12091: Added TypeScript translation extraction support#1967mikadamczyk wants to merge 6 commits into
mikadamczyk wants to merge 6 commits into
Conversation
mikadamczyk
force-pushed
the
feature/IBX-12091-typescript-translation-extraction
branch
from
July 16, 2026 08:51
5198656 to
8b44786
Compare
mikadamczyk
marked this pull request as ready for review
July 20, 2026 10:19
GrabowskiM
requested changes
Jul 20, 2026
GrabowskiM
approved these changes
Jul 20, 2026
albozek
force-pushed
the
feature/IBX-12091-typescript-translation-extraction
branch
from
July 20, 2026 13:49
26d6cc2 to
8b9bbb0
Compare
|
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
tbialcz and
wiewiurdp
and removed request for
a team
July 21, 2026 11:40
konradoboza
approved these changes
Jul 21, 2026
| use Symfony\Component\Process\InputStream; | ||
| use Symfony\Component\Process\Process; | ||
|
|
||
| final class TypeScriptExtractorClient |
Contributor
There was a problem hiding this comment.
Suggested change
| final class TypeScriptExtractorClient | |
| final readonly class TypeScriptExtractorClient |
|
|
||
| final class TypeScriptExtractorClient | ||
| { | ||
| private const DEFAULT_RESPONSE_TIMEOUT_SECONDS = 30.0; |
Contributor
There was a problem hiding this comment.
Suggested change
| private const DEFAULT_RESPONSE_TIMEOUT_SECONDS = 30.0; | |
| private const float DEFAULT_RESPONSE_TIMEOUT_SECONDS = 30.0; |
| $this->parserScriptPath = $parserScriptPath ?? __DIR__ . '/typescript_translation_extractor.mjs'; | ||
| } | ||
|
|
||
| public function __destruct() |
Contributor
There was a problem hiding this comment.
Can this have a return type?
| use SplFileInfo; | ||
| use Twig\Node\Node as TwigNode; | ||
|
|
||
| final class TypeScriptFileVisitor implements FileVisitorInterface, LoggerAwareInterface |
Contributor
There was a problem hiding this comment.
Suggested change
| final class TypeScriptFileVisitor implements FileVisitorInterface, LoggerAwareInterface | |
| final readonly class TypeScriptFileVisitor implements FileVisitorInterface, LoggerAwareInterface |
| * @param array<mixed> $ast | ||
| */ | ||
| public function visitPhpFile(SplFileInfo $file, MessageCatalogue $catalogue, array $ast): void | ||
| { |
Contributor
There was a problem hiding this comment.
Should we provide a comment why it is empty? 😉 Same goes for the Twig below.
wiewiurdp
reviewed
Jul 21, 2026
|
|
||
| public function testServeModeProcessesMultipleFilesSequentiallyAndSurvivesPerFileErrors(): void | ||
| { | ||
| $goodFile = tempnam(sys_get_temp_dir(), 'ts_extractor_') . '.ts'; |
Contributor
There was a problem hiding this comment.
tempnam() creates the file immediately. Appending .ts only modifies the returned path, so file_put_contents() creates a second file and the original temporary file is never removed. Could we rename the file instead, as done in testExtractsExpectedMessages()? The same applies to the other tempnam(...).'.ts' occurrences.
wiewiurdp
approved these changes
Jul 21, 2026
barw4
approved these changes
Jul 22, 2026
|
|
||
| foreach ($warnings as $warning) { | ||
| if (is_string($warning)) { | ||
| $this->logger?->error($warning); |
Contributor
There was a problem hiding this comment.
Nitpick but shouldn't it be warning per method's name and variables' names?
| $extractionResponse['error'], | ||
| )); | ||
|
|
||
| return null; |
Contributor
There was a problem hiding this comment.
Would it make sense to narrow down the return type to an empty array since the method's name implies messages? In this case we won't need check from line 40.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds TypeScript translation extraction support for
Translator.trans()andTranslator.transChoice()calls, including translation descriptions from@Desccomments. The extractor uses a persistent Node.js process with runtime validation, response timeouts, error handling, and automatic restart after failures. The implementation separates the JMS visitor from process management and installs frontend dependencies in the backend CI job so the tests can run correctly.For QA:
Documentation: