IBX-12067: New fonts#1965
Open
tischsoic wants to merge 4 commits into
Open
Conversation
tischsoic
force-pushed
the
ds-development
branch
2 times, most recently
from
July 15, 2026 10:58
f474be6 to
ed8b2e2
Compare
Mulish becomes the body font ($ibexa-font-family), Manrope stays for headings, and JetBrains Mono is used for code via Bootstrap's $font-family-monospace (new $ibexa-font-family-code). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The security-base CSS entry pulled the raw precompiled ids-assets styles.css, whose @font-face URLs point at the server root (/font/...) and 404. Use ibexa-ids-assets.scss instead (as the layout entry does), so the DS styles are recompiled with the correct assets base path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
tischsoic
force-pushed
the
IBX-12067-new-fonts
branch
from
July 21, 2026 12:33
396919c to
45597fc
Compare
tischsoic
marked this pull request as ready for review
July 21, 2026 12:39
Reference the DS typography module instead of hardcoding the Mulish / Manrope / JetBrains Mono stacks, so the fonts have a single source of truth in design-system-60. Uses a namespaced @use to avoid pulling in the DS font-size variables that admin-ui deliberately overrides. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ibexa-workflow-automation-1
Bot
requested review from
GrabowskiM,
OstafinL,
albozek,
alekmick and
dew326
and removed request for
a team
July 21, 2026 13:00
|
alekmick
approved these changes
Jul 21, 2026
GrabowskiM
approved these changes
Jul 22, 2026
OstafinL
reviewed
Jul 22, 2026
| @use '@ibexa-admin-ui/src/bundle/Resources/public/scss/functions/calculate.rem' as *; | ||
| @use '@ibexa-admin-ui-assets/src/bundle/Resources/public/vendors/ids-assets/dist/scss/variables/colors' as *; | ||
| @use '@ibexa-admin-ui-assets/src/bundle/Resources/public/vendors/ids-assets/dist/scss/variables/shadows' as *; | ||
| @use '@ibexa-admin-ui-assets/src/bundle/Resources/public/vendors/ids-assets/dist/scss/variables/typography' as ids-typography; |
Contributor
There was a problem hiding this comment.
Suggested change
| @use '@ibexa-admin-ui-assets/src/bundle/Resources/public/vendors/ids-assets/dist/scss/variables/typography' as ids-typography; | |
| @use '@ids-assets/scss/variables/typography' as ids-typography; |
and above if you agree?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: