fix: update deps to build under pnpm link - #869
Draft
antigremlin wants to merge 2 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
4 Skipped Deployments
|
antigremlin
commented
Dec 18, 2025
| "react": "^18.3.1", | ||
| "react-dom": "^18.3.1", | ||
| "react-toastify": "^10.0.6", | ||
| "starknet": "7.6.4", |
Contributor
Author
There was a problem hiding this comment.
Starknet fails to resolve as a peer dependency under pnpm link because of a major version conflict.
antigremlin
commented
Dec 18, 2025
| "starknet": "7.6.4", | ||
| "starknetkit": "2.6.1", | ||
| "viem": "^2.21.41", | ||
| "viem": "^2.21.45", |
Contributor
Author
There was a problem hiding this comment.
This is to align versions with the monorepo
antigremlin
commented
Dec 18, 2025
| "viem": "^2.21.45", | ||
| "wagmi": "^2.12.26", | ||
| "zod": "3.21.4", | ||
| "zod": "3.25.76", |
Contributor
Author
There was a problem hiding this comment.
This is to align versions with the monorepo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are draft fixes to the build system to allow building under
pnpm link. We will try to avoidpnpm linkin general but it will take more work and most of the fixes are correct even without it (except that the starknet dependency is questionable).