Rr/additional testnet warp routes#59
Open
Roee-87 wants to merge 4 commits into
Open
Conversation
Collaborator
|
Two differences from the mainnet implementation in #58: 1. Dead All 5 programs accept async function finalize_transfer_remote(..., signer: address) {
let actual_remote_router = remote_routers.get(destination);
assert_eq(actual_remote_router, unverified_remote_router);
// signer is never used
dispatch_future.await();
token_future.await();
}The mainnet programs in #58 don't have this parameter at all. 2.
But |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds four warp routes to be deployed to Aleo Testnet:
These four routes include modifications to
transfer_remoteandtransfer_remote_with_hookwhich replacesself.signerwithself.calleralong with adding dedicated transfer remote methods that invokeself.signer. The remainder of the existing warp routes will be upgraded with these changes.Note that
test_hyp_warp_token_eth.aleois already deployed to testnet but was not part of the repository.