Post the Docker image build results to the shared CI Slack channel - #6903
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
albertvillanova
force-pushed
the
align-slack-channels
branch
from
August 26, 2026 10:37
9d8c75d to
80e42c3
Compare
Member
Author
|
Merging this PR as this just addresses a specific request by @qgallouedec: #6895 (comment)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sends the Docker image build results to the shared CI Slack channel, like every other workflow.
Motivation
docker-build.ymlwas the only workflow pointing to its own channel, as noted in revision #6895 (comment). Every other workflow declaresCI_SLACK_CHANNELonce at the workflow level and passes it at each call site, so the thirteen call sites did not all resolve the channel the same way.Note that this changes where those notifications are delivered.
To do on merge
CI_DOCKER_CHANNELrepository secret. It is no longer referenced anywhere once this PR is merged, and deleting it is a repository setting rather than something this PR can do.Changes
CI_SLACK_CHANNELat the workflow level indocker-build.yml, from the same secret as the other workflowsPost to Slacksteps, in place of the Docker specific channelNote
Low Risk
Only changes which Slack channel receives CI notifications; no runtime or build logic changes.
Overview
Aligns Docker image build Slack notifications with the rest of the repo’s CI workflows.
docker-build.ymlnow sets workflow-levelCI_SLACK_CHANNELfromCI_PUSH_MAIN_CHANNEL(same pattern as workflows likeslow-tests.yml). BothPost to Slacksteps (trlandtrl-dev) passenv.CI_SLACK_CHANNELinstead ofCI_DOCKER_CHANNEL, so build results land in the shared CI channel rather than the Docker-only channel. After merge,CI_DOCKER_CHANNELcan be removed from repo secrets.Reviewed by Cursor Bugbot for commit 80e42c3. Bugbot is set up for automated code reviews on this repo. Configure here.