feat: Add automated testing framework and fix critical issues#171
Open
ghshhf wants to merge 3 commits into
Open
feat: Add automated testing framework and fix critical issues#171ghshhf wants to merge 3 commits into
ghshhf wants to merge 3 commits into
Conversation
added 3 commits
June 14, 2026 04:02
…lls (P1), add OpenCode support (P2) - Fix AGENTS.md missing YAML frontmatter (fixes huggingface#121, huggingface#79) - Update huggingface-llm-trainer and trl-training descriptions to clarify cloud vs local training - Add skill selection guidance to both duplicate skills - Create opencode.json for OpenCode support (fixes huggingface#74)
- Add pytest-based testing framework with 10 tests (7 skill format + 3 script validation) - Create tests/ directory with conftest.py, test_skill_format.py, test_scripts.py - Add CI/CD workflow (.github/workflows/ci.yml) for automated testing - Add test dependencies (requirements-test.txt, pytest.ini) - Fix YAML frontmatter issues in trl-training and huggingface-llm-trainer SKILL.md files - Fix Windows line endings (CRLF -> LF) in modified SKILL.md files - Make tests Windows-compatible (skip executable check on Windows) - All tests now pass (10 passed, 1 skipped) Test coverage: - Skill format validation (YAML frontmatter, name/description fields, naming conventions) - Script validation (Python syntax, Shell executable, script existence) - AGENTS.md validation (YAML frontmatter) Closes huggingface#121, huggingface#79, huggingface#163, huggingface#74 (related issues from previous commits)
- Comprehensive report of all work done - Test framework documentation - Usage instructions - Next steps and recommendations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
This PR adds a comprehensive automated testing framework and fixes several critical issues in the Hugging Face Skills project.
✅ Changes Made
1. Critical Fixes (P0 - P1)
Fix AGENTS.md YAML frontmatter (Fixes Critical: AGENTS.md missing YAML frontmatter (Update overrides manual fixes) #121, Failures during install. #79)
nameanddescriptionfields toagentsmd/AGENTS.mdCoordinate duplicate skills (Fixes TODO -- Reconcile hf-llm-trainer with new trl auto skill #163)
huggingface-llm-trainerandtrl-trainingdescriptions2. New Features (P2)
opencode.jsonconfiguration file3. Automated Testing Framework 🧪
Added 10 tests (7 skill format + 3 script validation)
Added CI/CD workflow
.github/workflows/ci.ymlTest-driven improvements
📊 Impact
🧪 Testing
Local Testing
CI/CD
📸 Test Results
📚 Documentation
AUTOMATED_TESTING_COMPLETE.md- Complete implementation reportPROJECT_ANALYSIS_REPORT.md- Project analysis and recommendations🔗 Related Issues
✅ Checklist
Thank you for maintaining this amazing project! 😊