Skip to content

Refactor/typings auto discovery#831

Open
hinogi wants to merge 3 commits into
huggingface:mainfrom
hinogi:refactor/typings-auto-_discovery
Open

Refactor/typings auto discovery#831
hinogi wants to merge 3 commits into
huggingface:mainfrom
hinogi:refactor/typings-auto-_discovery

Conversation

@hinogi

@hinogi hinogi commented Jun 21, 2026

Copy link
Copy Markdown

Summary

  • refactored typing annotations for auto _discovery to use built in types
  • added missing generic types and type annotations for dict

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • New environment
  • Refactoring

Alignment Checklist

Before submitting, verify:

  • I have read .claude/docs/PRINCIPLES.md and this PR aligns with our principles
  • I have checked .claude/docs/INVARIANTS.md and no invariants are violated
  • I have run /pre-submit-pr (or bash .claude/hooks/lint.sh and tests) and addressed all issues

RFC Status

  • Not required (bug fix, docs, minor refactoring)
  • RFC exists: #___
  • RFC needed (will create before merge)

Test Plan

Claude Code Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant