Skip to content

HGI-11002: Add error classification to raise correct errors - #19

Open
raheelhotglue wants to merge 5 commits into
mainfrom
feature/hgi-11002
Open

HGI-11002: Add error classification to raise correct errors#19
raheelhotglue wants to merge 5 commits into
mainfrom
feature/hgi-11002

Conversation

@raheelhotglue

Copy link
Copy Markdown

Alerting level on invalidcredserror is none

coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

@hotgluexyz hotgluexyz deleted a comment from coderabbitai Bot Aug 21, 2026
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Review Change Stack

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Pro Plus

Run ID: 8000a074-6641-4f10-994c-40f95863529a

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Pro Plus

Run ID: e33efc0f-c3b1-43b6-867f-3f2b90ec02fe

📥 Commits

Reviewing files that changed from the base of the PR and between fd76d22 and 372ea6f.

📒 Files selected for processing (2)
  • tap_airwallex/exceptions.py
  • tap_airwallex/tap.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The tap now classifies Airwallex authentication and rate-limit responses with specific exceptions. It detects permission errors from response content and configures alerting for these exceptions.

Changes

Airwallex error alerting

Layer / File(s) Summary
Response error classification
tap_airwallex/exceptions.py, tap_airwallex/client.py
Permission hints are detected from response JSON. Authentication responses raise permission or credential errors. Rate-limit responses raise RetriableAPIError.
Tap alerting configuration
tap_airwallex/tap.py
The tap uses error-level alerting and disables alerts for InvalidCredentialsError and InsufficientPermissionsError.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 372ea

The change adds error classification for authentication failures. The remaining concern is limited to documenting the accepted 401/403 response contract, with no demonstrated user-impacting defect or merge-blocking risk at the current head.

Suggested reviewers: keyn4

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: classifying Airwallex errors so the code raises the correct exception types.
Description check ✅ Passed The description relates to the changeset by identifying the alerting-level change for InvalidCredentialsError.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/hgi-11002

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@raheelhotglue

Copy link
Copy Markdown
Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

Comment thread tap_airwallex/client.py Outdated
Comment thread tap_airwallex/exceptions.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants