Skip to content

HGI-11008: Add IsInventoryExpirationDateEnabled element in schema - #2

Merged
cesar-lima1 merged 1 commit into
mainfrom
feature/hgi-11008
Aug 24, 2026
Merged

HGI-11008: Add IsInventoryExpirationDateEnabled element in schema#2
cesar-lima1 merged 1 commit into
mainfrom
feature/hgi-11008

Conversation

@mianazmatali9

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Pro

Run ID: 08da0e16-b466-4731-a645-9c4df78e11db

📥 Commits

Reviewing files that changed from the base of the PR and between 925cd87 and beb36f2.

📒 Files selected for processing (1)
  • qbwc_common/qbd_xml_schemas/qbxml130.xsd

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The qbXML 13.0 schema adds the optional IsInventoryExpirationDateEnabled boolean element to ItemsAndInventoryPreferences.

Changes

Inventory expiration schema

Layer / File(s) Summary
Inventory expiration preference contract
qbwc_common/qbd_xml_schemas/qbxml130.xsd
The schema declares IsInventoryExpirationDateEnabled with type BOOLTYPE and references it as an optional field in ItemsAndInventoryPreferences.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to beb36

This is a localized schema addition, and no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: cesar-lima1

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so the change has no author-provided context beyond the title. Add a brief description that explains the schema update and the purpose of the new optional element.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the schema change and names the added IsInventoryExpirationDateEnabled element.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/hgi-11008

Comment @coderabbitai help to get the list of available commands.

@cesar-lima1
cesar-lima1 merged commit a50edb2 into main Aug 24, 2026
2 checks passed
@cesar-lima1
cesar-lima1 deleted the feature/hgi-11008 branch August 24, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants