Skip to content

Fix/minor prestasi#87

Merged
albertchriss merged 5 commits into
developfrom
fix/minor-prestasi
Nov 19, 2025
Merged

Fix/minor prestasi#87
albertchriss merged 5 commits into
developfrom
fix/minor-prestasi

Conversation

@inRiza

@inRiza inRiza commented Nov 18, 2025

Copy link
Copy Markdown
Member

Fix UI Overlay Problem and Add Routes For Prestasi and Dashboard

Before

  • Overlay component issue on edit details page
  • Zod validation skipped for jenisPrestasi field on add prestasi schema
  • Route on home prestasi is directly to add prestasi page (changing the route to history-prestasi page)

After

  • [DONE] Fix overlay componen issue on edit details page
  • [DONE] Add zod validation for empty input field for jenisPrestasi
  • [DONE] Add routes for history prestasi from prestasi options, route for dashboard-people and cnc (only visible to significance of role), and add a floating button in history prestasi to add new prestasi
  • [REFACTOR] Refactor some certain duplication on empty state form to make sure clean code on prestasi page

@vercel

vercel Bot commented Nov 18, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hmif-app-fe Ready Ready Preview Comment Nov 18, 2025 2:22pm

@inRiza inRiza requested a review from albertchriss November 18, 2025 14:14
@albertchriss albertchriss merged commit 18dec87 into develop Nov 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants