fix: convert_frames_to_video uses .png as images and exports video with green overlay #147
Open
Amit0617 wants to merge 12 commits into
Open
fix: convert_frames_to_video uses .png as images and exports video with green overlay #147Amit0617 wants to merge 12 commits into
.png as images and exports video with green overlay #147Amit0617 wants to merge 12 commits into
Conversation
Owner
|
Thanks for the PR. Composing RGBA frames with a green background is imo too counter-intuitive and is only useful for people who wish to post-process the videos. An alternative solution is to allow the users to preprocess the frames themselves if necessary. |
Author
Like? Allow them to choose a custom colour? I had looked for |
limited to 1 object relative path for weights workspace path setting for videos restore and cleanup
releases for all os
…te Python version, and enhance artifact handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
frames for rgba mode were transparent and hence in
.pngformat which it wasn't detecting..mp4format doesn't support transparency. Exporting video with green overlay as shown in GUI can be helpful for any processing like background removal in video editors.Other option is exporting
.movfile (which supports transparency) but that creates large file sizes.fixes #146