fix: ignore workflows-repo in eslint config#104
Merged
Conversation
The release workflow checks out heroku/npm-release-workflows into ./workflows-repo, causing `eslint .` to lint that repo's source files and fail with 158 errors. Ignore the directory so lint scopes to this package only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
heroku/npm-release-workflowsinto./workflows-repobefore runningnpm run lint. Becauseeslint .walks the whole tree, it lints the workflow repo's own source and fails with 158 errors (single-quote rules, node: protocol, etc.).workflows-repo/**toeslint.config.mjsignores so lint scopes to this package's files only.Test plan
workflows-repo/directory with a deliberately bad.mjsfile and rannpm run lint; output now reports only the 4 pre-existing warnings insrc/index.ts(0 errors).