Handle reactiveVal labels for shiny >=1.12#661
Merged
Conversation
Detect the installed shiny version and use the appropriate internal label helper: keep using shiny:::rvalSrcrefToLabel for <1.12.0, and use shiny:::rassignSrcrefToLabel for >=1.12.0, providing a defaultLabel that includes a unique id. Also extract the call srcref to a variable to avoid repeated attr calls and ensure stable label generation across shiny versions.
schloerke
force-pushed
the
fix-reactive-val-label
branch
from
da25d21 to
4b22008
Compare
schloerke
had a problem deploying
to
github-pages
GitHub Actions
Failure
schloerke
force-pushed
the
fix-reactive-val-label
branch
from
ffea8da to
ffd7683
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect the installed shiny version and use the appropriate internal label helper: keep using
shiny:::rvalSrcrefToLabelfor <1.12.0, and useshiny:::rassignSrcrefToLabelfor >=1.12.0. Also extract the call srcref to a variable to avoid repeated attr calls and ensure stable label generation across shiny versions.Fixes #659