Skip to content

Add dark mode toggle#10

Open
ezraaslan wants to merge 4 commits into
hackclub:mainfrom
ezraaslan:main
Open

Add dark mode toggle#10
ezraaslan wants to merge 4 commits into
hackclub:mainfrom
ezraaslan:main

Conversation

@ezraaslan

Copy link
Copy Markdown

I added a button that sits in the navbar and is used to toggle dark mode. It works on all pages within website

@vercel

vercel Bot commented Apr 7, 2026

Copy link
Copy Markdown

@ezraaslan is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@tiredkangaroo

Copy link
Copy Markdown
Contributor

just a bit of feedback:

it kinda destroys the boxes

notice where there's borders and background color changes, they've all become one color. this appears to happen on all pages with all of the boxes.

Screenshot 2026-04-21 at 6 12 41 PM Screenshot 2026-04-21 at 6 12 25 PM Screenshot 2026-04-21 at 6 15 02 PM Screenshot 2026-04-21 at 6 14 54 PM

inconsistent dark mode

gallery.html
Screenshot 2026-04-21 at 6 17 51 PM

contrast issues

these changes appear to change the regular text color, but not the ones assigned for special text.
Screenshot 2026-04-21 at 6 21 39 PM
Screenshot 2026-04-21 at 6 21 35 PM
the shade of the special text works well on a light background, but not so well on a dark one.

i apologize if this comes off a bit nitpicky but these were just some issues i found.

@ezraaslan

Copy link
Copy Markdown
Author

thanks for the feedback! ill make the changes.
I also had a question -- this pr fails the vercel authorization check. is that bad? how can i fix/change that?

@tiredkangaroo

Copy link
Copy Markdown
Contributor

thanks! no worries about vercel authorization. swirl doesn't even use vercel anyway lol

@ezraaslan

Copy link
Copy Markdown
Author

I fixed up your comments and I think the pr is ready for another look

@tiredkangaroo

Copy link
Copy Markdown
Contributor

okay i see that you've made some pretty good changes! thanks!

  • notice how on the box with the "Your website must..." has a slightly different background color than what surrounds it in light mode. in dark mode, they're the same color.
Screenshot 2026-04-25 at 11 15 04 AM Screenshot 2026-04-25 at 11 15 14 AM
  • the gallery page still has the inconsistent dark mode.

just those two, and i think it's ready to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants