chore: remove the unmaintained pure-JS lexer port#204
Open
BridgeAR wants to merge 1 commit into
Open
Conversation
lexer.js reimplemented the WebAssembly lexer in hand-written JS kept in sync by hand. It is unreachable through the package `exports` (only `.` and `./js` are exposed - the wasm and asm.js builds) and `chomp test` never ran it, so it could drift silently. The asm.js build already covers the no-WebAssembly case. The unit harness defaults to the wasm build; the `if (!js)` skips run unconditionally now, as they already did under wasm and asm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the hand-written pure-JS
lexer.js- a manual reimplementation of the WebAssembly lexer that had to be kept in sync by hand. It is unreachable through the packageexports(.-> wasm,./js-> asm.js) and is not run bychomp test, so it could drift silently with no consumer. The asm.js build already covers the no-WebAssembly case.The unit harness now defaults to the wasm build, and the
if (!js)skips become unconditional - they already ran under wasm and asm.Test plan
chomp test(wasm + asm): 132 passing on both.