Fix Windows build with Clang/LLVM toolchain#1885
Open
gamander wants to merge 1 commit into
Open
Conversation
This commit fixes compilation errors when building GmSSL on Windows with clang-cl and ninja. Changes: - include/gmssl/endian.h: Add #include <stdint.h> for uint32_t/uint64_t types - include/gmssl/kyber.h: Add extern to zeta[] declaration to avoid duplicate symbols - src/tls_*.c (6 files): Guard POSIX headers fcntl.h and sys/select.h with #ifndef WIN32, keep errno.h on all platforms - CMakeLists.txt: Enable CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS for MSVC and Clang on Windows, preserving MinGW behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes compilation errors when building GmSSL on Windows with clang-cl and ninja.
Changes:
include/gmssl/endian.h: Add #include <stdint.h> for uint32_t/uint64_t types
include/gmssl/kyber.h: Add extern to zeta[] declaration to avoid duplicate symbols
src/tls_*.c (6 files): Guard POSIX headers fcntl.h and sys/select.h with #ifndef WIN32, keep errno.h on all platforms
CMakeLists.txt: Enable CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS for MSVC and Clang on Windows, preserving MinGW behavior