Add all inline elements to avoid wrong space breaking#76
Conversation
|
Note: the failure in travis-ci is due to nondeterminism of the setup. It's not related to my PR. You can request for a rebuild (I don't have a permission to do so), and it probably will now pass. |
|
I've been swamped and only recently was able to dig in and think about this.
Many years ago when I was new to Racket, I found it strange that this writes a leading newline: (require xml)
(display-xml/content
(document-element
(read-xml (open-input-string
"<html></html>"))))=> And then in the Racket web-server I saw it wrote a doctype, but not a newline, followed by So when I did this markdown package for use in frog, I emulated this in That was what was nagging at me, about this PR. I knew there was something, but I couldn't find time to focus and recall that. Fast forward some years, and frog doesn't even use However I wonder if it would break anything else. e.g. Pollen uses this package. TL;DR I think the PR is good, except we should keep the leading newline. If that really bugs you, then we should add an optional keyword argument for it, which defaults to true for backward compatibility. |
|
@sorawee If you're reading this in email, the previous comment is better read here on GitHub -- I made a few edits to clarify. I don't think GitHub re-sends edits as emails. |
2 participants
Fix #75