GCI1024 [Team OSER][2025] - Amar salhi code add iac rules 1 - #398
GCI1024 [Team OSER][2025] - Amar salhi code add iac rules 1#398AmarSALHI-code wants to merge 4 commits into
Conversation
|
This rule is really interesting (and actually often implemented via Kyverno or admission controllers), but I'm not sure it is relevant regarding the green code initiative? |
AmarSALHI-code
changed the title
AmarSALHI-code
changed the title
MP-Aubay
changed the title
|
|
||
| Participe à une orchestration plus efficace et économe. | ||
|
|
||
| == Compliant Code Example |
There was a problem hiding this comment.
could you please add a "non-compliant" example to have a comparison ?
| @@ -0,0 +1,16 @@ | |||
| { | |||
| "title": "Avoid Spring repository call in loop or stream operations", | |||
| "type": "ECO_CODE", | |||
There was a problem hiding this comment.
type unknown : please check in sonarqube documentaion (custom plugin development) what values we can put here (maybe CODE_SMELL ?)
| "status": "todo", | ||
| "remediation": { | ||
| "func": "Constant\/Issue", | ||
| "constantCost": "? min" |
There was a problem hiding this comment.
evaluate how many time we spend to go from non compliant code to compliant code
| @@ -0,0 +1,16 @@ | |||
| { | |||
There was a problem hiding this comment.
the path of this file is wrong ...
please check another example
JSON file will be inside root directory of "GCI1024"
MP-Aubay
left a comment
MP-Aubay
left a comment
There was a problem hiding this comment.
Thank you for you PR, please Update also CHANGELOG.md.
I think for now, this rule is more a best practice more than a green code rule, probe will restart pod but if it continue to fail it will not killed it (as I fastly read in doc).
We need more proof to make this rule relevant.
b282cf0 to
3de8021
Compare
| - 🚫 Non applicable rule | ||
|
|
||
| | Rule key | Name | Description | Reference/Validation | Java | Php | JS | Python | Rust | C# | HTML | | ||
| | Rule key | Name | Description | Reference/Validation | Docker | Kuberenetes | Ansible| Terrafomr |CloudFormation | |
There was a problem hiding this comment.
Typo on Terraform (Terrafomr)
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | ||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
|
||
| ## [Unreleased] |
There was a problem hiding this comment.
Don't change the Unreleased, it will be update by CI
| - 🚫 Non applicable rule | ||
|
|
||
| | Rule key | Name | Description | Reference/Validation | Java | Php | JS | Python | Rust | C# | HTML | | ||
| | Rule key | Name | Description | Reference/Validation | Docker | Kuberenetes | Ansible| Terrafomr |CloudFormation | |
There was a problem hiding this comment.
Maybe add the table after the existing one, to avoid modify the header
|
|
||
| Additional information available on: | ||
|
|
||
| * Research articles: |
There was a problem hiding this comment.
Theses articles do not seems to talk about probe (did not read it entirely)
|
This PR has been automatically marked as stale because it has no activity for 60 days. |
github-project-automation
Bot
moved this to Todo
in Hackathon Kanban - RULES-SPECIFICATIONS
4 participants
No description provided.