GCI99 OptimizeSquareComputation #Python #DLG #RulesSpecifications - #383
Merged
dedece35 merged 4 commits intoJul 8, 2025
Merged
Conversation
cleophass
commented
May 15, 2025
cleophass
commented
Contributor
- Rule specifcations for GCI99 OptimizeSquareComputation
- Definition Of Done checked ✅
- Directly put GCI99 because it's absent from Rules.md
- (This rule may be apply to other language)
Co-authored-by: DataLabGroupe-CreditAgricole <GITHUB.DATALABGROUPE@CREDIT-AGRICOLE-SA.FR>
Co-authored-by: DataLabGroupe-CreditAgricole <GITHUB.DATALABGROUPE@CREDIT-AGRICOLE-SA.FR>
dedece35
requested changes
Jul 2, 2025
dedece35
left a comment
dedece35
left a comment
Member
There was a problem hiding this comment.
is this rule also useable for x**3 and so on ?
Contributor
Author
@dedece35 yes, but I think that for a developer, in terms of readability, we can stop at x**2 because for a power of 4, for example, writing xxx*x in the code isn't necessarily compliant. |
Co-authored-by: DataLabGroupe-CreditAgricole <GITHUB.DATALABGROUPE@CREDIT-AGRICOLE-SA.FR>
dedece35
previously approved these changes
Jul 8, 2025
dedece35
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.