Fix compas-brep API use in Lap and Pocket - #843
Open
ericgozzi wants to merge 3 commits into
Open
Conversation
Pocket, Lap, and BTLxPart's Brep-handling code still called the old compas.geometry.brep API (face.nurbssurface, face.frame_at) which no longer exists on compas_brep's BrepFace. face.surface now returns a Plane directly for planar faces, so no NurbsSurface/frame_at detour is needed; only genuinely curved faces need surface.frame_at. Along the way, face.surface didn't account for face.is_reversed, so opposite faces of a box reported identical normals instead of opposite ones - fixed by flipping the normal for reversed faces. Also fixes _get_optimal_ref_side_index in Pocket and Lap, where edge.curve already returns a Line directly (no .points attribute to unpack). Pocket.apply additionally now raises a clear FeatureApplicationError when start_depth is negative (the pocket volume lies entirely outside the element's material on the ref_side's outward side) instead of letting a corrupted/erased geometry reach the boolean subtraction.
ericgozzi
requested review from
chenkasirer and
obucklin
and
a lite review from Copilot
and removed request for
Copilot
August 10, 2026 09:00
Line is no longer needed in pocket.py now that _get_optimal_ref_side_index uses edge.curve directly instead of wrapping it in Line(*curve.points).
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #843 +/- ##
==========================================
- Coverage 82.67% 82.57% -0.11%
==========================================
Files 83 83
Lines 12009 12018 +9
==========================================
- Hits 9929 9924 -5
- Misses 2080 2094 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates COMPAS Timber’s fabrication features to match the current compas_brep Brep API, removing calls to deprecated/removed methods and fixing orientation handling for reversed Brep faces so downstream plane/frame computations behave correctly.
Changes:
- Replace deprecated Brep face surface access (
nurbssurface,frame_at) withface.surfaceand handle planar vs curved faces appropriately. - Correct face orientation handling by flipping normals/frames when
face.is_reversedso opposing faces report opposing normals. - Fix
Pocket/Lapref-side edge handling (edge.curvealready returns aLine) and add an earlyFeatureApplicationErrorfor negativePocket.start_depth.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/compas_timber/fabrication/pocket.py | Update Brep face plane extraction + edge handling; add explicit error for negative start_depth to prevent invalid boolean subtraction. |
| src/compas_timber/fabrication/lap.py | Update Brep face plane extraction + edge handling to use the current Brep API and correct reversed-face orientation. |
| src/compas_timber/fabrication/btlx.py | Make BTLx shape export robust for planar faces by avoiding frame_at on Plane and correcting reversed-face orientation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+349
to
+353
| for face in volume.faces: | ||
| plane = face.surface | ||
| if face.is_reversed: | ||
| plane.normal = -plane.normal | ||
| planes.append(plane) |
Comment on lines
+417
to
+421
| for face in volume.faces: | ||
| plane = face.surface | ||
| if face.is_reversed: | ||
| plane.normal = -plane.normal | ||
| planes.append(plane) |
Comment on lines
+563
to
+567
| if self.start_depth < -TOL.absolute: | ||
| raise FeatureApplicationError( | ||
| None, | ||
| geometry.transformed(element.modeltransformation), | ||
| "Pocket's start_depth ({:.4f}) is negative: the pocket volume lies entirely outside " |
Comment on lines
+654
to
+658
| surface = face.surface | ||
| # planar faces (the common case) return a Plane, which has no frame_at (parameter-independent | ||
| # anyway); only genuinely curved faces (NurbsSurface, etc.) need parametric evaluation. | ||
| frame = Frame.from_plane(surface) if isinstance(surface, Plane) else surface.frame_at(0.5, 0.5) | ||
| if face.is_reversed: |
chenkasirer
reviewed
Aug 19, 2026
| scaled_geometry = self.element.geometry.scaled(self._scale_factor) | ||
| for face in scaled_geometry.faces: | ||
| pts = [] | ||
| frame = face.surface.frame_at(0.5, 0.5) |
Contributor
There was a problem hiding this comment.
Hey! I think these should be fixed upstream. could you check if gramaziokohler/compas_brep#8
solves these issues?
it should be as easy as calling face.from_at() which should now get you the properly oriented frame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pocket, Lap, and BTLxPart's Brep-handling code still called the old compas.geometry.brep API (face.nurbssurface, face.frame_at) which no longer exists on compas_brep's BrepFace. face.surface now returns a Plane directly for planar faces, so no NurbsSurface/frame_at detour is needed; only genuinely curved faces need surface.frame_at.
Along the way, face.surface didn't account for face.is_reversed, so opposite faces of a box reported identical normals instead of opposite ones - fixed by flipping the normal for reversed faces.
Also fixes _get_optimal_ref_side_index in Pocket and Lap, where edge.curve already returns a Line directly (no .points attribute to unpack).
Pocket.apply additionally now raises a clear FeatureApplicationError when start_depth is negative (the pocket volume lies entirely outside the element's material on the ref_side's outward side) instead of letting a corrupted/erased geometry reach the boolean subtraction.
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas_timber.datastructures.Beam.class_diagrams.rst(if appropriate).