Record compas_timber version in BTLx FileHistory ProgramVersion - #840
Merged
Conversation
The exported FileHistory block named COMPAS_Timber as the producing program but stamped ProgramVersion with the version of compas, the geometry kernel underneath it. Stamp both, compas_timber first, so the fabrication artifact identifies the program that generated its geometry. Also fixes the file_history_attibutes local variable typo. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #840 +/- ##
==========================================
- Coverage 82.67% 82.64% -0.04%
==========================================
Files 83 83
Lines 12005 12006 +1
==========================================
- Hits 9925 9922 -3
- Misses 2080 2084 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…NGELOG conflict) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exported BTLx files name
ProgramName="COMPAS_Timber"but stampProgramVersionwith the version of compas, the geometry kernel — so the fabrication artifact can't identify the version of the program that generated its geometry. The string dates to the initial fabrication PR (#138) and survived the BTLxWriter rewrite (#354) verbatim; it was never a decision. This stamps both, compas_timber first:COMPAS Timber: 2.2.0; COMPAS: 2.15.1.Also updates the
test_btlx_file_historyassertion (verified red without the fix, green with it) and fixes afile_history_attibutestypo in the same block.🤖 Generated with Claude Code