KButtJoint - #731
Open
ericgozzi wants to merge 8 commits into
Open
Conversation
ericgozzi
marked this pull request as ready for review
March 31, 2026 08:30
ericgozzi
requested review from
chenkasirer,
obucklin and
papachap
and removed request for
papachap
March 31, 2026 08:31
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new KButtJoint connection type to COMPAS Timber to support K-topology butt-style joints where multiple main beams connect along the length of a cross beam, and exposes it through the public connections API.
Changes:
- Introduces
KButtJointimplementation with extension + feature generation logic. - Registers
KButtJointincompas_timber.connectionspublic API. - Updates developer docs/changelog and adds a dedicated test module.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/compas_timber/connections/k_butt.py |
New KButtJoint class implementation (geometry, features, serialization fields, cluster promotion). |
src/compas_timber/connections/__init__.py |
Exposes KButtJoint via imports and __all__. |
tests/compas_timber/test_k_butt_joint.py |
Adds basic creation, joinery processing, and serialization/deserialization tests. |
docs/contribution/class_diagrams.md |
Documents the new joint in the class diagram/inheritance list. |
CHANGELOG.md |
Notes the addition of KButtJoint under Unreleased. |
Contributor
|
@ericgozzi I know you were working on this with @papachap. Please let us know if you want some "external" review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #730 and #729
This pull request introduces the new
KButtJointclass to the timber connections module, enabling support for K-Butt type joints where beams are joined along the length of a third (cross) beam. The changes include the implementation of the joint logic, integration into the package, updates to documentation, and comprehensive tests to ensure correct behavior.Key changes:
New Feature: KButtJoint Implementation
KButtJointclass insrc/compas_timber/connections/k_butt.py, providing geometry logic, feature addition, and serialization for K-Butt joints. This includes methods for identifying coplanarity, adding fabrication features, and handling milling volumes for pockets and laps.Integration into the Package
KButtJointin the connections module by updating imports and the__all__list insrc/compas_timber/connections/__init__.py, making it available for use throughout the package. [1] [2]Documentation Updates
CHANGELOG.mdto note the addition ofKButtJoint.KButtJointto the class diagrams and inheritance hierarchy indocs/contribution/class_diagrams.mdfor improved developer documentation. [1] [2]Testing
KButtJointintests/compas_timber/test_k_butt_joint.py, covering creation, joinery processing, and model serialization/deserialization.What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas_timber.datastructures.Beam.class_diagrams.rst(if appropriate).