Skip to content

GH Components for Plate Joints - #495

Merged
chenkasirer merged 16 commits into
mainfrom
plate_joint_GH_Components
Sep 19, 2025
Merged

GH Components for Plate Joints#495
chenkasirer merged 16 commits into
mainfrom
plate_joint_GH_Components

Conversation

@obucklin

@obucklin obucklin commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

This PR adds the GH components for Plate Joints that utilize the new JointRule workflow.

Several components have been reworked to improve readability and reliability, including the model component. Some refactorings take advantage of the implicit list handling of GH components. If this is an issue we can go back to explicit handling, but I know that at least on the plate, this creates a problem when passing multiple openings, where the uset would have to explicitly pass trees to create plates with multiple openings.

Anyways, this is ready for review and testing.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_timber.datastructures.Beam.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@codecov

codecov Bot commented Jul 14, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.97%. Comparing base (23a8cbb) to head (93c6c86).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
src/compas_timber/ghpython/ghcomponent_helpers.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #495   +/-   ##
=======================================
  Coverage   65.97%   65.97%           
=======================================
  Files          76       76           
  Lines       11064    11064           
=======================================
  Hits         7300     7300           
  Misses       3764     3764           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@obucklin obucklin linked an issue Jul 29, 2025 that may be closed by this pull request
@obucklin

obucklin commented Sep 2, 2025

Copy link
Copy Markdown
Contributor Author

Hey now that the new JointRule workflow has been merged, these GH_Components should be added. @Stryzhevska would you please take some time in the next couple weeks to test the new components? If you have time, it would also be great to add icons where they are missing or copies of old icons. Thanks!!

@obucklin

obucklin commented Sep 2, 2025

Copy link
Copy Markdown
Contributor Author

Hey now that the new JointRule workflow has been merged, these GH_Components should be added. @Stryzhevska would you please take some time in the next couple weeks to test the new components? If you have time, it would also be great to add icons where they are missing or copies of old icons. Thanks!!

Additionally I started making some example GH scripts which we should distribute with the yak package on food4rhino. I'm not sure how to do that exactly, or whether we should put them in the repo. for the moment they are [here](G:\Shared drives\GKR_Projects\333_Compas_Timber\CT_GH_example_scripts). Please feel free to add more example scripts.

@obucklin
obucklin marked this pull request as ready for review September 3, 2025 14:59

@chenkasirer chenkasirer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once missing icons are added

@Stryzhevska thanks for testing!

if we really want to maintain Rhino7 compatibility we should probably run a test on those as well, but that's probably a lot of effort. I'm leaning towards dropping Rhino7 altogether. I leave it to you to decide.

@chenkasirer
chenkasirer merged commit 49d558f into main Sep 19, 2025
16 checks passed
@chenkasirer
chenkasirer deleted the plate_joint_GH_Components branch September 19, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PlateJoint rules GH Components

3 participants