GH Components for Plate Joints - #495
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #495 +/- ##
=======================================
Coverage 65.97% 65.97%
=======================================
Files 76 76
Lines 11064 11064
=======================================
Hits 7300 7300
Misses 3764 3764 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey now that the new JointRule workflow has been merged, these GH_Components should be added. @Stryzhevska would you please take some time in the next couple weeks to test the new components? If you have time, it would also be great to add icons where they are missing or copies of old icons. Thanks!! |
Additionally I started making some example GH scripts which we should distribute with the yak package on food4rhino. I'm not sure how to do that exactly, or whether we should put them in the repo. for the moment they are [here](G:\Shared drives\GKR_Projects\333_Compas_Timber\CT_GH_example_scripts). Please feel free to add more example scripts. |
… to the ones I was testing. Changes proposed are based on the code in components from the example file.
chenkasirer
left a comment
There was a problem hiding this comment.
LGTM once missing icons are added
@Stryzhevska thanks for testing!
if we really want to maintain Rhino7 compatibility we should probably run a test on those as well, but that's probably a lot of effort. I'm leaning towards dropping Rhino7 altogether. I leave it to you to decide.
This PR adds the GH components for Plate Joints that utilize the new JointRule workflow.
Several components have been reworked to improve readability and reliability, including the
modelcomponent. Some refactorings take advantage of the implicit list handling of GH components. If this is an issue we can go back to explicit handling, but I know that at least on the plate, this creates a problem when passing multiple openings, where the uset would have to explicitly pass trees to create plates with multiple openings.Anyways, this is ready for review and testing.
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas_timber.datastructures.Beam.