fix: restore memorable agent ids - #6
Merged
Merged
Conversation
Moving the launcher into this package dropped unique-names-generator, and ids became `agent-k3n8fq2p`. They are how an agent is recognised in logs and in the UI, so the readable form matters: "brave-red-panda-of-japan", the same shape the Python launcher produces with coolname.generate_slug(4). The name parts are slugified rather than only having spaces replaced, which is what the frontend did. Country names carry dots, accents and apostrophes, so ids like "…-of-u.s.-outlying-islands" were possible before. A test covers the shape, and caught exactly that case. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ups, we drop this in the move