Skip to content

fix(generator2): dedupe transitive shared fragment imports - #667

Merged
knaeckeKami merged 2 commits into
gql-dart:masterfrom
knaeckeKami:fix/generator2-transitive-shared-fragments
Mar 15, 2026
Merged

fix(generator2): dedupe transitive shared fragment imports#667
knaeckeKami merged 2 commits into
gql-dart:masterfrom
knaeckeKami:fix/generator2-transitive-shared-fragments

Conversation

@knaeckeKami

Copy link
Copy Markdown
Collaborator

Summary

  • dedupe transitive shared fragment imports by traversing document sources uniquely by URL
  • memoize source loading by AssetId so shared imports are parsed once across recursive reads
  • add generator and end-to-end regression coverage for shared transitive fragments

Testing

  • ./.github/workflows/scripts/validate-formatting.sh
  • dart test test/source_test.dart test/build_runner_smoke_test.dart test/end_to_end_mirror_test.dart
  • dart test test/runtime_test.dart
  • dart analyze

@netlify

netlify Bot commented Mar 15, 2026

Copy link
Copy Markdown

Deploy Preview for ferry-gql ready!

Name Link
🔨 Latest commit 50eb833
🔍 Latest deploy log https://app.netlify.com/projects/ferry-gql/deploys/69b6adbc68dba90008c486f3
😎 Deploy Preview https://deploy-preview-667--ferry-gql.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knaeckeKami
knaeckeKami merged commit 862f448 into gql-dart:master Mar 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant