feat!: eslint use new config format (plus update deps)#935
Merged
Conversation
Collaborator
|
@cstrahan, thank you for opening your PR! We don't run tests from forks, do you think you could contribute to this PR to get the changes in? Currently I see it's failing node 18 because of a dependency that requires node 20. I think the easiest thing would be to fix that specific dependency, or else migrate this library to node 20 (which I think is too laborious for now but open to it given the upcoming breaking change). |
tonycoco
force-pushed
the
eslint-plus-deps-update
branch
from
1a7969e to
0c3c171
Compare
Collaborator
Author
|
The primary issue is with |
Collaborator
Author
|
I fixed the tests, but the license check is still failing. |
Collaborator
Author
|
|
tonycoco
force-pushed
the
eslint-plus-deps-update
branch
2 times, most recently
from
f2c92c0 to
72ab003
Compare
tonycoco
force-pushed
the
eslint-plus-deps-update
branch
from
72ab003 to
565a78e
Compare
sofisl
changed the title
sofisl
approved these changes
Dec 3, 2025
Collaborator
|
LGTM but want to get @feywind opinion on it |
feywind
approved these changes
Dec 4, 2025
This was referenced Dec 4, 2025
Closed
Contributor
|
Thanks everyone! Sorry, I missed the @ message earlier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.