Throw JsonSyntaxException for null map keys in array form#3056
Open
ATKasem wants to merge 1 commit into
Open
Conversation
When deserializing array-encoded map entries, a JSON null key was passed through to LinkedTreeMap and surfaced as an unchecked NullPointerException. Reject null keys at the adapter boundary so malformed input stays within Gson's JsonParseException contract. Fixes google#3037
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3037
Summary
nullmap keys inMapTypeAdapterFactory.Adapter.readbefore insertionJsonSyntaxExceptioninstead of lettingLinkedTreeMap.putsurface an uncheckedNullPointerExceptionRoot cause
Array-encoded map entries (
[[key, value], ...]) decode a JSONnullkey to Javanulland pass it straight to the backing map.LinkedTreeMaprejects that withNullPointerException: key == null, which escapes Gson's documentedJsonParseExceptionerror contract.Test plan
mvn -pl gson -Dtest=MapAsArrayTypeAdapterTest testmvn -pl gson -Dtest=MapTest,MapAsArrayTypeAdapterTest test