Conversation
thomasvl
previously approved these changes
Aug 20, 2025
thomasvl
reviewed
Aug 20, 2025
| @end | ||
|
|
||
| @interface GTMKeyValueObservingHelper : NSObject { | ||
| @private |
Member
There was a problem hiding this comment.
Looks like this might have been needed?
Collaborator
Author
There was a problem hiding this comment.
Why do you think this was needed?
Member
There was a problem hiding this comment.
My mistake, I was looking at the errors for the CI jobs failing, and didn't read close enough; I was thinking it was something about the decl, but the problem is https://github.com/google/google-toolbox-for-mac/blob/main/GoogleToolboxForMac.podspec#L69-L74
Probably needs to have inserted:
sp.requires_arc = 'Foundation/GTMNSObject+KeyValueObserving.{h,m}'
So it's like the Logger entry: https://github.com/google/google-toolbox-for-mac/blob/main/GoogleToolboxForMac.podspec#L76-L78
thomasvl
added a commit
to thomasvl/google-toolbox-for-mac
that referenced
this pull request
Sep 3, 2025
This reverts commit 27f71f8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.