Skip to content

test: fix flaky tests#160

Merged
witochandra merged 1 commit into
masterfrom
test/fix-flaky-tests
Jun 20, 2026
Merged

test: fix flaky tests#160
witochandra merged 1 commit into
masterfrom
test/fix-flaky-tests

Conversation

@witochandra

Copy link
Copy Markdown
Collaborator

Fixes these flaky tests on CI:

https://github.com/gojek/heimdall/actions/runs/27264843190/job/80519290697

--- FAIL: TestHystrixHTTPClientRetriesWithBudgetGetOnFailure5xx (0.15s)
    hystrix_client_test.go:380: 
        	Error Trace:	/home/runner/work/heimdall/heimdall/hystrix/hystrix_client_test.go:380
        	Error:      	Received unexpected error:
        	            	hystrix: timeout
        	Test:       	TestHystrixHTTPClientRetriesWithBudgetGetOnFailure5xx

https://github.com/gojek/heimdall/actions/runs/27264843190/job/82395349637

--- FAIL: TestHTTPClientDoContextCancelledBeforeRetry (0.00s)
    client_test.go:705: 
        	Error Trace:	/home/runner/work/heimdall/heimdall/httpclient/client_test.go:705
        	Error:      	An error is expected but got nil.
        	Test:       	TestHTTPClientDoContextCancelledBeforeRetry

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 72.423%. remained the same — test/fix-flaky-tests into master

3 similar comments
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 72.423%. remained the same — test/fix-flaky-tests into master

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 72.423%. remained the same — test/fix-flaky-tests into master

@coveralls

coveralls commented Jun 20, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 72.423%. remained the same — test/fix-flaky-tests into master

@witochandra witochandra merged commit 67eaa73 into master Jun 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants