Fix moving/duplicating file stored in the root res:// folder - #121795
Open
PeacefulPieDev wants to merge 1 commit into
Open
Fix moving/duplicating file stored in the root res:// folder#121795PeacefulPieDev wants to merge 1 commit into
res:// folder#121795PeacefulPieDev wants to merge 1 commit into
Conversation
KoBeWi
reviewed
Jul 26, 2026
AThousandShips
changed the title
AThousandShips
changed the title
res:// folder
Process separately the case when file is stored in the root res:// folder. Mark root item as selected.
Author
|
Sorry for messing commits up. Something went wrong during squashing all the commits and still they are present. I will fix it tomorrow. |
PeacefulPieDev
marked this pull request as draft
July 28, 2026 06:35
PeacefulPieDev
force-pushed
the
fix-filesystem-move-duplicate-dialog
branch
from
July 28, 2026 06:42
fd20ef7 to
71d2c49
Compare
PeacefulPieDev
marked this pull request as ready for review
July 28, 2026 06:50
Author
|
Well, now i used AI to guide me through git commands to update the PR. Using force push branch history seems wrong still, at least now it contains only the updated commit. |
KoBeWi
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved changes from 08e3358 by processing separately the case when moved/duplicated item is being stored in the root folder (res://), which was completely ignored previosly.
What problem(s) does this PR solve?
Additional information
Previosly, the case where file's base directory contains only res:// folder is skipped. The res:// is being trimmed and the root item is never being selected back. That's why the assert is raised later.
I propose to process this case separately and explicitly. It is also may be usefull to add an assert for
parts.is_empty()case on next lines, instead of just break , since the situation may never arise.@KoBeWi , could you please take a look? Am I not missing anything with this dialog processing?