Skip to content

Change mentions of "member" to "property" where appropriate - #12182

Open
Mickeon wants to merge 1 commit into
masterfrom
ow-my-member-hurts
Open

Change mentions of "member" to "property" where appropriate#12182
Mickeon wants to merge 1 commit into
masterfrom
ow-my-member-hurts

Conversation

@Mickeon

@Mickeon Mickeon commented Jul 26, 2026

Copy link
Copy Markdown
Member

See godotengine/godot#121793 and RocketChat discussion

I will explore and think about this more.
Unlike the class reference, the manual seems particularly keen on distinguishing between "member variable" and "property".

@Mickeon
Mickeon force-pushed the ow-my-member-hurts branch 3 times, most recently from 565d23e to 89ac5f5 Compare July 27, 2026 20:46
@Mickeon
Mickeon requested a review from HolonProduction July 27, 2026 20:47
@Mickeon
Mickeon marked this pull request as ready for review July 27, 2026 20:47
@Mickeon
Mickeon requested review from a team as code owners July 27, 2026 20:47
@Mickeon
Mickeon removed request for a team July 27, 2026 20:48
@paulloz

paulloz commented Jul 27, 2026

Copy link
Copy Markdown
Member

I'd be cautious with these on C# pages and code blocks, since the term property holds a different meaning there. Readers might end up with the idea that Godot bindings only work on (C#) properties, and not also on field.

@Mickeon

Mickeon commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

I acknowledge it. I was waiting for your kind of review to know where to scale back.

Comment thread tutorials/3d/introduction_to_3d.rst Outdated
Comment thread tutorials/plugins/running_code_in_the_editor.rst Outdated
Comment thread tutorials/shaders/shader_reference/shading_language.rst Outdated
Comment thread tutorials/shaders/shader_reference/shading_language.rst Outdated
@Mickeon
Mickeon force-pushed the ow-my-member-hurts branch from 89ac5f5 to a7f7756 Compare July 30, 2026 13:40
@Mickeon
Mickeon requested a review from AThousandShips July 30, 2026 13:40

@Calinou Calinou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@AThousandShips AThousandShips left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants