fix(eval): reject CB mixed TTFT regressions and harden harness#600
Merged
Conversation
Single-seq prefill gains must not excuse a serving-path TTFT regression. Also retry accuracy /completion on missing probs or HTTP 5xx, verify ensure_sparkinfer binaries, and prefer CUDA 13.0 on eval boxes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cb_ttft > main/tol→eval:REJECT+regression-cb-ttft, so single-seq pp gains cannot excuse a serving-path TTFT regression./completionretries on missing probs / HTTP 5xx,ensure_sparkinferverifies runtime binaries after build, prefer CUDA 13.0 on boxes.Test plan
python3 bench/scripts/test_guard_reject.py(CB TTFT gate cases)python3 bench/scripts/test_cb_prefill_score.pyeval:REJECT+ gate rowfailpass, prior label unchanged